Product Onboarding: Allow Template Products to be previewed #8091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecarrion
added
the
feature: products onboarding
Generated by 🚫 dangerJS |
Collaborator
You can test the changes from this Pull Request by:
|
ealeksandrov
approved these changes
Nov 11, 2022
Contributor
ealeksandrov
left a comment
ealeksandrov
left a comment
There was a problem hiding this comment.
There are couple of failing tests to check:
- testProductHasNoChangesFromEditActionsOfTheSameData
- testObservablesFromUpdatingProductPasswordRemotely
| return hasUnsavedChanges() | ||
| case .edit, .readonly: | ||
| return true | ||
| } |
| let commonDate = Date() | ||
| return emptyProduct.copy(date: commonDate, dateCreated: commonDate, dateModified: commonDate, dateOnSaleStart: commonDate, dateOnSaleEnd: commonDate) == | ||
| product.copy(date: commonDate, dateCreated: commonDate, dateModified: commonDate, dateOnSaleStart: commonDate, dateOnSaleEnd: commonDate) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8071
Why
Prior to this PR, template products where considered unsaved new products, so the preview button was disabled for them.
Here, I'm making sure that a template product is able to be previewed as soon as it is created.
How
Added an
isEmptyproperty onEditableProductModelto be able to differentiate a product with content from an empty prroduct.Added a new
isNewTemplateProductonProductFormViewModelto identify a template product, which is when the original product has id zero and is not not empty.Refactored a bit the
shouldEnablePreviewButton()because I found it hard to read 😇Demo
Preview Template
Dont.Preview.Blank.mov
Disable preview on empty products
Preview.Template.mov
Testing
Note
The feature is currently only visible to users in the experiment treatment group. In the Audience section of the template experiment model, go to Variations > Manual Assignment and use the bookmarklet to assign yourself (your a8c account) to the treatment group.
You will need to log in to the app with your a8c account to see the experiment while it is in staging (not launched to users yet).
Steps
RELEASE-NOTES.txtif necessary.